Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from from_str to parse #299

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Switch from from_str to parse #299

merged 2 commits into from
Oct 23, 2023

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Oct 20, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Switch from from_str to parse which requires one import less.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@Hinton Hinton requested a review from dani-garcia October 20, 2023 16:20
@bitwarden-bot
Copy link

bitwarden-bot commented Oct 20, 2023 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – a0c8fe10-0b3a-4a2a-93f6-b01a89d4f3a5

No New Or Fixed Issues Found

@Hinton Hinton merged commit 1601ecd into master Oct 23, 2023
45 checks passed
@Hinton Hinton deleted the ps/parse branch October 23, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dani-garcia dani-garcia dani-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hinton @bitwarden-bot @dani-garcia